[docs] Modernize DemoFrame #20664
Merged
[docs] Modernize DemoFrame #20664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
docs/react-frame-component
branch
from
c51f38d to
3738008
Compare
Details of bundle changes.Comparing: 324f9c5...6423280 Details of page changes
|
oliviertassinari
approved these changes
Apr 21, 2020
eps1lon
commented
Apr 21, 2020
|
|
||
| // NoSsr fixes a strange concurrency issue with iframe and quick React mount/unmount |
There was a problem hiding this comment.
@oliviertassinari Do you recall the symptoms of that issue?
There was a problem hiding this comment.
I could find #13705 as the origin.
There was a problem hiding this comment.
We would need to make sure https://deploy-preview-20664--material-ui.netlify.app/zh/components/drawers/ displays without a crash. It was before hooks.
There was a problem hiding this comment.
I'll check locally if /zh/components/drawers/ crashes. That was the issue in #13705, right?
There was a problem hiding this comment.
Does not crash locally in small and large viewporet.
I got warnings in concurrent mode for "state transition during render" which is indicative of some issue with react-frame-component. Might just be an issue with class components and concurrent mode.
Hopefully this fixes concurrent mode issues as well. If not then at least let it not be a bug in react :)
This was referenced Apr 29, 2020
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component causes some issues in concurrent mode. I used the opportunity to simplify the implementation:
remove state.ready and instead derive it directlyuse a ref to the insertion point div instead ofwindow['jss-insertion-point']. That's a cute alternative towindow.document.querySelector('#jss-insertion-point')but, let's be honest, it's just showing of knowledge of hidden browser APIs 😉containerprop. We only have a single usage for it and can be replace with a ref-based approach which isolates the demo better.Tested on IE11 (win10) and Safari 13.0 (macOS 10.15).